Ensure generated property names for methods named "new" are quoted #55750
+365
−218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // See getNameForSymbolFromNameType for a stringy equivalent | ||
| function getPropertyNameNodeForSymbolFromNameType(symbol: Symbol, context: NodeBuilderContext, singleQuote?: boolean, stringNamed?: boolean) { | ||
| function getPropertyNameNodeForSymbolFromNameType(symbol: Symbol, context: NodeBuilderContext, singleQuote: boolean, stringNamed: boolean, isMethod: boolean) { |
There was a problem hiding this comment.
Idle observation: Lint rule for functions with optional parameters which are never not supplied? 🤔
There was a problem hiding this comment.
Probably better as some external pass, as ts-eslint doesn't really do stuff cross-project. Technically possible with the new ProjectService thing, maybe.
RyanCavanaugh
approved these changes
Sep 15, 2023
snovader
pushed a commit
to mestro-se/TypeScript
that referenced
this pull request
Sep 23, 2023
…icrosoft#55750) Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55075
Closes #55109
This effectively replaces #55109, instead using a fix in
createPropertyNameNodeForIdentifierOrLiteralinstead of the emitter. If you look at the last commit, you'll see that the only change to TS emit was removed, which I believe to be correct as the code was able to be written that way in the first place so should be legal.While I was here, I made the parameters to
createPropertyNameNodeForIdentifierOrLiteralrequired, which showed that there was an existing bug for this in a code fix. Likely I need a test for this. It also shows that this call doesn't respectstringNamedeither, which unfortunately requires some type info I didn't look into getting quite yet.cc @Andarist